Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle ghost now leaves the users mob visible #6065

Merged
merged 5 commits into from
Apr 20, 2024
Merged

Toggle ghost now leaves the users mob visible #6065

merged 5 commits into from
Apr 20, 2024

Conversation

vero5123
Copy link
Contributor

@vero5123 vero5123 commented Apr 1, 2024

About the pull request

Fixes #5894

Explain why it's good for the game

bug fix

Changelog

🆑
fix: toggling ghost vision now keeps the user's mob visible.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Apr 1, 2024
@fira
Copy link
Member

fira commented Apr 2, 2024

I'm not sure removing ghost plane handling is much of a fix

@vero5123
Copy link
Contributor Author

vero5123 commented Apr 2, 2024 •
edited
Loading

I'm not sure removing ghost plane handling is much of a fix

I mean, it fixes it. I don't think it's too hacky. Do we really have to mess with the alpha of the ghost plane lighting and set it to 0?

@Blundir
Copy link
Contributor

Blundir commented Apr 7, 2024

This pr isn't exactly optimal feature-wise, seeing no ghosts at all is good for making screenshots both locally and on server itself, this pr just completely removes the ability, without providing alternatives.

@vero5123
Copy link
Contributor Author

vero5123 commented Apr 7, 2024 •
edited
Loading

This pr isn't exactly optimal feature-wise, seeing no ghosts at all is good for making screenshots both locally and on server itself, this pr just completely removes the ability, without providing alternatives.

No it doesn't, you toggle ghost visibility, which hides all mobs but yourself and then you can toggle self visibility which hides your mob from your pov and others.

PowerfulBacon
PowerfulBacon reviewed Apr 11, 2024
View reviewed changes
Copy link

@PowerfulBacon PowerfulBacon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there things on the ghost layer that would be inadvertantly hidden by changing the see_invisible flags?

@vero5123
Copy link
Contributor Author

vero5123 commented Apr 11, 2024 •
edited
Loading

Are there things on the ghost layer that would be inadvertantly hidden by changing the see_invisible flags?

Afik, No. Just the ghosts. It's just changing the visibility from 60 to 59. There is nothing in between.

@Drulikar Drulikar added this pull request to the merge queue Apr 20, 2024
Merged via the queue into cmss13-devs:master with commit 9243cb6 Apr 20, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Apr 20, 2024
@cm13-github
Automatic changelog for PR #6065 [ci skip]
51d31a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PowerfulBacon PowerfulBacon PowerfulBacon left review comments

@Drulikar Drulikar Drulikar approved these changes

Assignees
No one assigned
Labels
Fix Fix one bug, make ten more
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ghost Vision & Self-Visibility borked
5 participants
@vero5123 @fira @Blundir @PowerfulBacon @Drulikar